Skip to content

Add DEPENDS_EXPLICIT_ONLY to remove implicit dependencies #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: rolling
Choose a base branch
from
Draft

Add DEPENDS_EXPLICIT_ONLY to remove implicit dependencies #238

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d1ea29
Add DEPENDS_EXPLICIT_ONLY to remove implicit dependencies
TonyWelte Sep 30, 2025
69e6e97
Use version check instead of bumping minimum cmake version
TonyWelte Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions rosidl_generator_py/cmake/custom_command.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@
# CMake does not allow `add_custom_command()` to depend on files generated in
# a different CMake subdirectory, and this command is invoked after an
# add_subdirectory() call.
if(${CMAKE_VERSION} VERSION_GREATER_EQUAL 3.27)
set(_dep_explicit_only DEPENDS_EXPLICIT_ONLY)
else()
set(_dep_explicit_only "")
endif()

add_custom_command(
OUTPUT ${_generated_extension_files} ${_generated_py_files} ${_generated_c_files}
# This assumes that python_cmake_module was found, which is always the case since this is only
Expand All @@ -28,6 +34,7 @@ add_custom_command(
DEPENDS ${target_dependencies} ${rosidl_generate_interfaces_TARGET}
COMMENT "Generating Python code for ROS interfaces"
VERBATIM
${_dep_explicit_only}
)

if(TARGET ${rosidl_generate_interfaces_TARGET}${_target_suffix})
Expand Down