Skip to content

refactor: Use std::conditional_variable in signal handler code #2999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jmachowinski wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

refactor: Use std::conditional_variable in signal handler code #2999

jmachowinski wants to merge 1 commit into from

Conversation

@jmachowinski
Copy link
Collaborator

@jmachowinski jmachowinski commented Nov 24, 2025

Code cleanup to use std::conditional_variable in the signal handler code instead of a custom home brew version.

Description

Reworked version of
#2998

@jmachowinski jmachowinski mentioned this pull request Nov 24, 2025
Closed
@jmachowinski jmachowinski force-pushed the sync_with_conditional branch 2 times, most recently from 1c2a717 to 096cc95 Compare November 24, 2025 15:23
fujitatomoya
fujitatomoya requested changes Nov 24, 2025
View reviewed changes
@jmachowinski jmachowinski force-pushed the sync_with_conditional branch 2 times, most recently from 52646ea to 399f671 Compare November 25, 2025 10:28
fujitatomoya
fujitatomoya approved these changes Nov 26, 2025
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmachowinski thanks for the fix, i will start the CI.

Note: not only the replacement of custom semaphore notification code for handling signals (SIGINT/SIGTERM) with std::condition_variable and related modern C++ synchronization primitives, but also having dedicated fields (atomic field) for SIGTERM and SIGINT allows the system to reliably record if each signal was received, even if they arrive close together or simultaneously.

@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Nov 26, 2025

Pulls: #2999
Gist: https://gist.githubusercontent.com/fujitatomoya/ff163fdb6450f491c07c7afa3dba0ceb/raw/f2952c0364cd9a9d6320782c2b5240aeee5837f2/ros2.repos
BUILD args: --packages-above-and-dependencies ‎rclcpp
TEST args: --packages-above ‎rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17607

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Nov 26, 2025

Pulls: #2999
Gist: https://gist.githubusercontent.com/fujitatomoya/09871ad60ca47d4c954d9f9333bb8108/raw/f2952c0364cd9a9d6320782c2b5240aeee5837f2/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17608

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@wjwwood
Copy link
Member

wjwwood commented Dec 4, 2025

From triage meeting: ci.ros2.org was down, but seems like it could be merged maybe?

@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Dec 4, 2025

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Dec 4, 2025

rebase

❌ Pull request can't be updated with latest base branch changes

Mergify needs the author permission to update the base branch of the pull request.
@jmachowinski needs to authorize modification on its head branch.

@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Dec 4, 2025

@jmachowinski can you rebase and restart CI?

refactor: Use std::conditional_variable in signal handler code
edee4fc 
Code cleanup to use std::conditional_variable in the signal handler
code instead of a custom home brew version.

Signed-off-by: Janosch Machowinski <[email protected]>
@jmachowinski jmachowinski force-pushed the sync_with_conditional branch from 399f671 to edee4fc Compare December 5, 2025 09:50
@jmachowinski
Copy link
Collaborator Author

jmachowinski commented Dec 5, 2025 •
edited
Loading

Pulls: #2999
Gist: https://gist.githubusercontent.com/jmachowinski/3df5465cccc7df140c22669ac9b723e1/raw/f2952c0364cd9a9d6320782c2b5240aeee5837f2/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17694

Started by user Janosch Machowinski

Running as SYSTEM
Building on the built-in node in workspace /var/lib/jenkins/workspace/ci_launcher

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status
    Triggering a new build of ci_linux-aarch64

Triggering a new build of ci_windows

Triggering a new build of ci_linux-rhel

Triggering a new build of ci_linux

Finished: SUCCESS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

@fujitatomoya fujitatomoya

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmachowinski @fujitatomoya @wjwwood