Revert "Updating client API to be able to remove pending requests" #1733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" This reverts commit bf752c7. Signed-off-by: Ivan Santiago Paunovic <[email protected]>
ivanpauno
force-pushed
the
revert-1728-ivanpauno/modified-client-api
branch
from
94059b3 to
e2cfabb
Compare
delete-merged-branch
bot
deleted the
revert-1728-ivanpauno/modified-client-api
branch
Member
|
Is there a new pr yet? |
ivanpauno
added a commit
that referenced
this pull request
Aug 23, 2021
* Revert "Revert "Updating client API to be able to remove pending requests (#1728)" (#1733)" This reverts commit d5f3d35. Signed-off-by: Ivan Santiago Paunovic <[email protected]> * Address peer review comments Signed-off-by: Ivan Santiago Paunovic <[email protected]> * Fix tests in rclcpp_components, rclcpp_lifecycle Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1728.
I clicked the merge button in the wrong window, sorry.