Skip to content

Conversation

@Theosakamg
Copy link

@Theosakamg Theosakamg commented Nov 1, 2016

Need to remove my Travis and Readme.

  • Packages node, services, topics...
  • New c/JNI message generator:
  • fixed Char converter
  • fixed fixed array type
  • fixed String array type
  • JNI cache
  • Documentation (JavaDoc)
  • Add Logger ROS (not official)
  • Add Parameter stack
  • More tests
  • Refactor JNI loading

@esteve
Copy link
Member

esteve commented Nov 13, 2016

@Theosakamg I'd love to merge your contributions, but unfortunately I can't merge this pull request as is. It's important that you split this into separate pull requests, here's a suggestion for how we could get there:

I haven't heard from you since you created this pull request, but you have continued to push changes, so I'm really happy that you're still interested in ros2_java ☺️

@esteve
Copy link
Member

esteve commented Nov 20, 2016

@Theosakamg ping. It's been 20 days since you submitted this pull request, but haven't heard from you and I don't know whether you plan to act on the feedback I gave you. What should I do with this pull request? Should I close it or wait?

@Theosakamg Theosakamg changed the title rclcpp design [WIP] rclcpp design Nov 20, 2016
@Theosakamg
Copy link
Author

@esteve sorry for the delay. I rename to WIP. more info => https://github.com/ros2java/design/issues/1#issuecomment-261808345

@Theosakamg Theosakamg closed this Nov 28, 2016
ivanpauno pushed a commit that referenced this pull request Apr 13, 2021
Use action-ros-ci version 0.0.19

Signed-off-by: Jacob Perron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants