-
Notifications
You must be signed in to change notification settings - Fork 109
Cleanup #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup #2
Conversation
|
This is awesome, thank you so much! If you don't mind, I'll split this PR into separate branches so each changeset is self contained. For example, I'd rather wait to merge the QoS stuff until it's integrated with JNI, but I can't do it if everything is part of the same PR. BTW, I've just added you to https://github.com/esteve/ros2_java/blob/master/THANKS |
|
I've created the following branches based on this PR: https://github.com/esteve/ros2_java/tree/Theosakamg-master I haven't created separate branches for the library loader and the logger because both are too intertwined, please separate the functionalities so I we can discuss them independently. |
|
@Theosakamg I'm closing this pull request. It hasn't been updated and I haven't heard from you since I created the separate branches. Anyway, I have fully implemented QoS in master (see esteve@c2bd039) and added support for logging via SLF4J, which works much better on Android than If there's anything else you'd like to see in Thanks for your contribution! |
Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Chris Lalancette <[email protected]>
Added :