Skip to content

Conversation

@Theosakamg
Copy link

Added :

  • JavaDoc
  • QoS (Profils only)
  • Unified loader

@Theosakamg Theosakamg mentioned this pull request Sep 10, 2016
@esteve
Copy link
Member

esteve commented Sep 12, 2016

This is awesome, thank you so much! If you don't mind, I'll split this PR into separate branches so each changeset is self contained. For example, I'd rather wait to merge the QoS stuff until it's integrated with JNI, but I can't do it if everything is part of the same PR.

BTW, I've just added you to https://github.com/esteve/ros2_java/blob/master/THANKS

@esteve
Copy link
Member

esteve commented Sep 26, 2016

I've created the following branches based on this PR:

https://github.com/esteve/ros2_java/tree/Theosakamg-master
https://github.com/esteve/ros2_java/tree/Theosakamg-qos
https://github.com/esteve/ros2_java/tree/Theosakamg-javadoc

I haven't created separate branches for the library loader and the logger because both are too intertwined, please separate the functionalities so I we can discuss them independently.

@esteve
Copy link
Member

esteve commented Oct 24, 2016

@Theosakamg I'm closing this pull request. It hasn't been updated and I haven't heard from you since I created the separate branches.

Anyway, I have fully implemented QoS in master (see esteve@c2bd039) and added support for logging via SLF4J, which works much better on Android than java.util.logging

If there's anything else you'd like to see in ros2_java, feel free to submit more pull requests, I'd love to get any improvements.

Thanks for your contribution!

@esteve esteve closed this Oct 24, 2016
clalancette added a commit to clalancette/ros2_java that referenced this pull request Aug 4, 2020
ivanpauno pushed a commit that referenced this pull request Nov 16, 2021
ivanpauno added a commit that referenced this pull request Nov 16, 2021
Signed-off-by: Chris Lalancette <[email protected]>

Co-authored-by: Chris Lalancette <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants