Add Node Options (port osrf/ros2_java#3) #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobperron
approved these changes
Nov 16, 2021
Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
This should make the code much easier to read. Signed-off-by: Chris Lalancette <[email protected]>
This makes it a lot nicer to use. Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
1. Check return value of malloc. 2. Get rid of unnecessary cast. Signed-off-by: Chris Lalancette <[email protected]>
ivanpauno
force-pushed
the
ivanpauno/port-osrf-#3
branch
from
321408c to
9fbb260
Compare
Contributor
|
FYI, @esteve |
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Member
Thank you guys for your hard work and for keeping me in the loop. I won't have time to review every PR, but it's nice to see the progress of your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #195.
Ports osrf#3