-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fix CI regression #5571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI regression #5571
Conversation
Signed-off-by: mini-1235 <[email protected]>
|
This should fix Also, these code aren't used now navigation2/nav2_simple_commander/nav2_simple_commander/utils.py Lines 27 to 59 in 9ed832e
should I keep it? |
I think its still useful 😉 Why was this causing an issue? I should have looked into this more, these have been historically flaky tests so I didn't think to look into it more than retriggering CI (yet) |
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
|
See https://app.circleci.com/pipelines/github/ros-navigation/navigation2/16271/workflows/d907caaa-ba46-4950-be7d-d807a7907f61/jobs/47564/tests for example It reports When I run these failing tests alone, they always pass. However, when running the entire package, these three tests consistently fail. I looked at the logs, and noticed that at the end of the wait test: I believe the failure is due to the wait test not fully cleaning up gazebo resources when it ends, possibly related to the latest Gazebo update I think, although I haven’t dug into it further yet |
|
I see, that would make sense |
Signed-off-by: mini-1235 <[email protected]>
Signed-off-by: mini-1235 <[email protected]>
Signed-off-by: mini-1235 <[email protected]>
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Description of how this change was tested
Future work that may be required in bullet points
For Maintainers:
backport-*.