-
Notifications
You must be signed in to change notification settings - Fork 429
Fix cmake deprecation #1780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cmake deprecation #1780
Conversation
Cmake version < then 3.10 is deprecated
saikishor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have decided in the PMC meeting to go to the minimum version for now
|
@mosfet80 I reverted my suggestions. Thank you for the comments |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1780 +/- ##
=======================================
Coverage 86.38% 86.38%
=======================================
Files 123 123
Lines 12240 12240
Branches 1024 1024
=======================================
Hits 10574 10574
Misses 1348 1348
Partials 318 318
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
christophfroehlich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
d7eca59
into
ros-controls:master
(cherry picked from commit d7eca59)
Co-authored-by: mosfet80 <[email protected]>
Cmake version < then 3.10 is deprecated
Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:
To send us a pull request, please:
colcon testandpre-commit run(requires you to install pre-commit bypip3 install pre-commit)