Skip to content

Conversation

@mosfet80
Copy link
Contributor

Cmake version < then 3.10 is deprecated

Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:

  1. Limited scope. Your PR should do one thing or one set of things. Avoid adding “random fixes” to PRs. Put those on separate PRs.
  2. Give your PR a descriptive title. Add a short summary, if required.
  3. Make sure the pipeline is green.
  4. Don’t be afraid to request reviews from maintainers.
  5. New code = new tests. If you are adding new functionality, always make sure to add some tests exercising the code and serving as live documentation of your original intention.

To send us a pull request, please:

  • Fork the repository.
  • Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  • Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
  • Commit to your fork using clear commit messages.
  • Send a pull request, answering any default questions in the pull request interface.
  • Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

Cmake version < then 3.10 is deprecated
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have decided in the PMC meeting to go to the minimum version for now

@saikishor
Copy link
Member

@mosfet80 I reverted my suggestions. Thank you for the comments

@codecov
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.38%. Comparing base (2800f21) to head (dba242e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1780   +/-   ##
=======================================
  Coverage   86.38%   86.38%           
=======================================
  Files         123      123           
  Lines       12240    12240           
  Branches     1024     1024           
=======================================
  Hits        10574    10574           
  Misses       1348     1348           
  Partials      318      318           
Flag Coverage Δ
unittests 86.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@christophfroehlich christophfroehlich added the backport-jazzy Triggers PR backport to ROS 2 jazzy. label Jun 30, 2025
@christophfroehlich christophfroehlich merged commit d7eca59 into ros-controls:master Jun 30, 2025
22 of 50 checks passed
mergify bot pushed a commit that referenced this pull request Jun 30, 2025
(cherry picked from commit d7eca59)
@mergify mergify bot mentioned this pull request Jun 30, 2025
6 tasks
christophfroehlich pushed a commit that referenced this pull request Jun 30, 2025
@mosfet80 mosfet80 deleted the patch-1 branch June 30, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants