Add new AntiWindup parameters to JTC #1759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
DasRoteSkelett,
bmagyar,
harderthan,
mamueluth,
mcbed,
olivier-stasse and
saikishor
joint_trajectory_controller/src/joint_trajectory_controller_parameters.yaml
Outdated
Show resolved
Hide resolved
joint_trajectory_controller/src/joint_trajectory_controller_parameters.yaml
Outdated
Show resolved
Hide resolved
joint_trajectory_controller/src/joint_trajectory_controller_parameters.yaml
Outdated
Show resolved
Hide resolved
github-actions
bot
requested review from
aprotyas,
arne48,
bijoua29,
destogl,
livanov93 and
progtologist
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1759 +/- ##
==========================================
- Coverage 86.29% 86.23% -0.07%
==========================================
Files 123 123
Lines 11941 11902 -39
Branches 995 993 -2
==========================================
- Hits 10305 10264 -41
- Misses 1333 1337 +4
+ Partials 303 301 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
saikishor
requested changes
Jun 17, 2025
Member
saikishor
left a comment
saikishor
left a comment
There was a problem hiding this comment.
In general it looks great. Just one minor thing
joint_trajectory_controller/src/joint_trajectory_controller_parameters.yaml
Show resolved
Hide resolved
Co-authored-by: Sai Kishor Kothakota <[email protected]>
saikishor
approved these changes
Jun 17, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
Co-authored-by: Sai Kishor Kothakota <[email protected]> (cherry picked from commit a4cc58d)
christophfroehlich
added a commit
that referenced
this pull request
Jun 18, 2025
Co-authored-by: Christoph Fröhlich <[email protected]> Co-authored-by: Sai Kishor Kothakota <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1585
See ros-controls/control_toolbox#400 and earlier.