Skip to content

Conversation

@saikishor
Copy link
Member

Might lead to similar errors like ros-controls/ros2_control#2243

It looks like the warn method is deprecated long back and they have removed it recently in ros2/rclpy#1456

@saikishor saikishor added the backport-jazzy Triggers PR backport to ROS 2 jazzy. label May 17, 2025
@codecov
Copy link

codecov bot commented May 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.69%. Comparing base (dc53641) to head (a6f155d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...est_nodes/publisher_joint_trajectory_controller.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1690   +/-   ##
=======================================
  Coverage   85.69%   85.69%           
=======================================
  Files         123      123           
  Lines       11896    11896           
  Branches     1015     1015           
=======================================
  Hits        10194    10194           
  Misses       1379     1379           
  Partials      323      323           
Flag Coverage Δ
unittests 85.69% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...est_nodes/publisher_joint_trajectory_controller.py 59.09% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@christophfroehlich christophfroehlich merged commit 7417abb into ros-controls:master May 17, 2025
19 of 24 checks passed
@christophfroehlich christophfroehlich deleted the fix/logger/warn branch May 17, 2025 21:21
mergify bot pushed a commit that referenced this pull request May 17, 2025
christophfroehlich pushed a commit that referenced this pull request May 17, 2025
nitin2606 pushed a commit to nitin2606/ros2_controllers that referenced this pull request May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants