[cernlib] avoid asan warning / maybe undefined behavior in h2root #19200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reported by asan /opt/root_src/misc/minicern/src/cernlib.c:82:18: runtime error: left shift of negative value -2012982016 /opt/root_src/misc/minicern/src/cernlib.c:83:18: runtime error: left shift of negative value -2012982016 /opt/root_src/misc/minicern/src/cernlib.c:102:12: runtime error: left shift of 1212370737 by 8 places cannot be represented in type 'int' /opt/root_src/misc/minicern/src/cernlib.c:102:39: runtime error: left shift of 1212370737 by 24 places cannot be represented in type 'int'
ferdymercury
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Test Results 20 files 20 suites 3d 8h 20m 12s ⏱️ Results for commit 9b628ac. ♻️ This comment has been updated with latest results. |
2 tasks
Collaborator
Author
|
Hi, I'd propose merging this as-is and moving the pending warnings to a new GH issue to keep track of those. |
couet
approved these changes
Jun 30, 2025
Member
Was the issue opened? |
Collaborator
Author
No, since this was not yet merged |
Collaborator
Author
is now #19329 |
guitargeek
approved these changes
Oct 18, 2025
Contributor
guitargeek
left a comment
guitargeek
left a comment
There was a problem hiding this comment.
Thanks! The new version is definitely more readable, besides addressing the warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
reported by asan