Skip to content

Conversation

danstepanov
Copy link
Member

@danstepanov danstepanov commented Oct 3, 2025

Description

Works for:

  • Nativewind v4.1.21 template
  • NativewindUI blank stack template
  • NativewindUI all components stack template
  • Blank template

Motivation and Context

How Has This Been Tested?

bun run test

@danstepanov
Copy link
Member Author

danstepanov commented Oct 3, 2025

@mrzachnugent there seems to be a series of type errors in /app/index.ts when creating the following templates, mind taking a look? It all works but the TS errors are annoying.

  1. clone the repo
  2. cd create-expo-stack/cli
  3. bun i
  4. bun run build
  5. bun run dev myTestProject --nativewindui --blank --overwrite or bun run dev myTestProject --nativewindui --overwrite

@danstepanov danstepanov requested a review from dannyhw October 3, 2025 00:37
@danstepanov
Copy link
Member Author

danstepanov commented Oct 3, 2025

@dannyhw i've fucked up the next branch a bit too much so I'm doing the following:

@danstepanov danstepanov changed the title add expo sdk 54 support Expo sdk 54 support Oct 3, 2025
@danstepanov danstepanov mentioned this pull request Oct 3, 2025
@mrzachnugent
Copy link
Contributor

@danstepanov For the type error: estimatedItemSize={200}, you can remove that line since it is no longer a prop (removing it doesn't break anything since it is done automatically with the latest version).

For the linting rules, the unused imports can be removed. And the progress indicator array item can be updated to:

  {
    name: 'Progress Indicator',
    component: function ProgressIndicatorExample() {
      const [progress, setProgress] = React.useState(13);
      const timeOutRef = React.useRef<ReturnType<typeof setTimeout> | null>(null);
      React.useEffect(() => {
        if (!timeOutRef.current) {
          timeOutRef.current = setTimeout(() => {
            setProgress((prev) => (prev >= 99 ? 0 : prev + 5));
          }, 1000);
        }
        return () => {
          if (timeOutRef.current) {
            clearTimeout(timeOutRef.current);
          }
        };
      }, []);
      return (
        <View className="p-4">
          <ProgressIndicator value={progress} />
        </View>
      );
    },
  },

@MOHAMED-LAAGUILI
Copy link

cool

@danstepanov danstepanov merged commit 0e9d284 into main Oct 6, 2025
1 check passed
@danstepanov danstepanov deleted the danstepanov/expo-sdk-54 branch October 6, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants