feat(commonjs): pass type of import to node-resolve #611
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
commonjsThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
#540
Description
cc @LarsDenBakker This is the necessary change to move forward with #540. When the commonjs plugin is resolving imports via
this.resolve, this will pass on a custom options object of the formThis can then be picked up by the node-resolve plugin via #540 to decide if whether it should add the
importor therequirecondition.I decided against a more general format here not because I do not think it would be useful but because it was the easiest to just solve the problem at hand and also avoid the need for a validation (i.e. the node-resolve logic would implement the mutual exclusivity of the
importandrequireconditions). However if we want to have general conditions, we would need to add another option that would possibly interact with this option, so this may be a bad idea after all. Feedback welcome.Once we agreed upon this PR, this can be merged at any time without this being a breaking change. Because even though it relies on new or even not-yet implemented features in Rollup and the node-resolve plugin, it will work gracefully with older versions as those will just ignore the custom parameter. And maybe this should actually be merged first so that when #540 is released, it can be fully functional from the start.