fix(typescript): revert #1653 #1880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 26, 2025
Collaborator
|
We're going to need a test to protect against future regressions that this revert fixes |
This reverts commit 40a38b1 This commit caused certain files to no longer be included in the project.
lukastaegert
force-pushed
the
revert/typescript/1653
branch
from
45afb0e to
4557841
Compare
Member
Author
|
I added a test. Without the revert, the test fails because it gets a warning that no declaration for the external module can be found. With the revert, the declaration is found again. |
Collaborator
|
Perfect! |
shellscape
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
typescriptThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
plugin-typescript12.1.3 cannot find modules with custom resolution logic #1877plugin-typescript12.1.3 doesn't respect theincludefield intsconfig.json#1878Description
This reverts #1653 as many users were experiencing issues. If we want the feature, a new attempt should be made that tests for the issues described in #1877 and #1878