forked from yffaffy/rollbar
-
Notifications
You must be signed in to change notification settings - Fork 21
Update v3 #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danielmorell
wants to merge
16
commits into
master
Choose a base branch
from
update/v3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update v3 #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianr
reviewed
Aug 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of review - added a few comments/questions.
Just a heads up: perhaps you can take a look at the implementation / fix for the security issue in #129. It also has a nice markdown file with security advises |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This is a major update the WordPress plugin. It includes an overhaul of most everything. Here is a high level list of everything that changed.
ROLLBAR_DISABLE_ADMIN
to remove the plugin settings page from the admin.ROLLBAR_SETTINGS
to configure the plugin without the admin page.ROLLBAR_CLIENT_ACCESS_TOKEN
constant or environment variable to set the client access token.WP_PROXY_BYPASS_HOSTS
,WP_PROXY_USERNAME
, andWP_PROXY_PASSWORD
for better proxy management.rollbar_api_admin_permission
filter to allow custom authorization of the admin API.rollbar_disable_admin
filter to allow custom disabling of the admin page.rollbar_php_config
filter to allow more exact control over Rollbar PHP configurations.rollbar_telemetry_actions
filter to allow control of which actions are logged via telemetry.rollbar_telemetry_custom_handlers
filter to allow custom control over what is logged in telemetry messages.Type of change
Related issues
Checklists
Development
Code review