Skip to content

Conversation

Chris53897
Copy link

#85

We need to wait after rollbar/rollbar v4 is stable.
After this it can be changed "rollbar/rollbar": "^3.1|^4.0",

This is just a proof of concept for changes in version 4.

@danielmorell
Copy link
Collaborator

I think we will also need to make some changes to the Tests/Fixtures/ErrorHandler class. It is not compatible with Monolog 3. We may need one class for Monolog 1 and 2 and another for Monolog 3.

@danielmorell danielmorell self-assigned this Mar 22, 2023
@danielmorell danielmorell added this to the v5.1.0 milestone Mar 22, 2023
@Chris53897
Copy link
Author

Chris53897 commented Mar 25, 2023

Thanks for the info. I just noticed that Version 4 is stable now and has a first release. Great
i will work on this as soon as i have some free time.

@danielmorell danielmorell self-requested a review April 11, 2023 09:55
Copy link
Collaborator

@danielmorell danielmorell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we have not needed the Tests\Fixtures\ErrorHandler class since v3. If you remove that class and update the version constraint for rollbar/rollbar in the composer.json to "^3.1 || ^4.0" I think the tests should pass.

@danielmorell danielmorell linked an issue Apr 11, 2023 that may be closed by this pull request
@Chris53897
Copy link
Author

I bumped the symfony version from 6.0 to 6.2.
This is the only one from the 6.x branch that is maintained https://symfony.com/releases#maintained-symfony-branches

Copy link
Collaborator

@danielmorell danielmorell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you @Chris53897!

@danielmorell danielmorell merged commit f867137 into rollbar:master May 2, 2023
@Chris53897 Chris53897 deleted the next/5.x/main-support-rollbar-v4 branch May 2, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Rollbar v4

3 participants