Create draft PR template #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pallasite99
commented
Jul 12, 2022
pallasite99
commented
- Fixes Add a PR template #47
Contributor
|
Can you add a status section on top with:
So that reviewers can identify the stage of the PR |
shukra-in-spirit
requested changes
Jul 12, 2022
Contributor
shukra-in-spirit
left a comment
shukra-in-spirit
left a comment
There was a problem hiding this comment.
can you also add a small section for linking it to the issue(s) that it is resolving,
Member
Author
|
@shukra-in-spirit sure I will. a linked issue(s) section and the status one, cool |
pallasite99
force-pushed
the
add-pr-template
branch
2 times, most recently
from
dcd8bb8 to
dcbac16
Compare
Member
Author
|
@shukra-in-spirit made the requested changes |
gives a draft PR template for each PR
pallasite99
force-pushed
the
add-pr-template
branch
from
0e6e254 to
0f2a78e
Compare
Want committers to perform an assertive action of ticking the checklist for the activities finished.
Contributor
|
I had missed out the issues mentioned at the top of the page.
Rest looks good to me. I am approving. Feel free to merge before the v0.2.0 release. |
shukra-in-spirit
approved these changes
Jul 13, 2022
Member
Author
|
Ok @shukra-in-spirit so I will squash and merge this here at this stage. Hopefully the next PR gets this template to work with 📦 |
Contributor
|
Keeping my fingers crossed for the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.