Skip to content

Conversation

@haani-niyaz
Copy link
Collaborator

@haani-niyaz haani-niyaz commented Jul 3, 2022

Hi @shukra-in-spirit @vancanhuit , I've raised this PR for review on:

  1. Documentation structure
  2. Quickstart content
  3. CI pages structure
  4. CI content for gitleaks, pre-commit, mkdocs-material and golangci-lint

The documentation on publish will look similar to:
https://haani-niyaz.github.io/golang-template-repository/

Closes #21 and #28.

Required actions:

@AlvinKuruvilla, there was an urgency to finish this piece of work so I've stepped in. Happy to discuss with you if required.

@jeffy-mathew
Copy link

since this is related to docs.
shall we use https://opencollective.com/vale to do a copy check?
https://github.com/errata-ai/vale-action - seems helpful in GitHub actions context

@haani-niyaz
Copy link
Collaborator Author

since this is related to docs. shall we use https://opencollective.com/vale to do a copy check? https://github.com/errata-ai/vale-action - seems helpful in GitHub actions context

This definitely looks interesting. We should have a story to explore it :)

For the purpose of this MR though, a more technical documentation review is required to validate if the information is helpful for repo owners to get started.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shukra-in-spirit shukra-in-spirit merged commit 14fe918 into main Jul 5, 2022
@haani-niyaz
Copy link
Collaborator Author

@shukra-in-spirit thanks for merging this. Just checking if gh-pages was setup in the repo as per:
#21 (comment)

The site is URL is retuning a 404 atm.

@shukra-in-spirit
Copy link
Contributor

Hey, I updated it.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 40 Code Smells

0.0% 0.0% Coverage
10.2% 10.2% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposal for docs in repo

4 participants