Skip to content

Conversation

@haani-niyaz
Copy link
Collaborator

Although we have secret scanning in our CI, if secrets are found it is already too late as the secrets have been committed to the repo. Instead add a pre-commit to shift left and detect early.

@haani-niyaz haani-niyaz added the enhancement New feature or request label Jul 2, 2022
Copy link
Contributor

@vancanhuit vancanhuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@haani-niyaz haani-niyaz merged commit 65f6af5 into main Jul 3, 2022
@haani-niyaz haani-niyaz deleted the gitleaks-pre-commit branch July 6, 2022 10:33
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants