Update locator to use p-mod-hidden class
#52
Conversation
Signed-off-by: Luca Giorgi <[email protected]>
| @@ -29,7 +29,7 @@ ${JLAB XP CARD} //div[contains(@class, 'jp-LauncherCard' | |||
| ${JLAB XP DOCK} //div[@id='jp-main-dock-panel'] | |||
| ${JLAB XP MENU ITEM} //li[contains(@class, 'p-Menu-item')] | |||
| ${JLAB XP MENU ITEM LABEL} //div[contains(@class, 'p-Menu-itemLabel')] | |||
| ${JLAB XP MENU ITEM ENABLED} ${JLAB XP MENU ITEM}\[not(contains(@class,'p-mod-disabled'))] | |||
| ${JLAB XP MENU ITEM ENABLED} ${JLAB XP MENU ITEM}\[not(contains(@class,'p-mod-hidden'))] | |||
There was a problem hiding this comment.
In light of this change, let's update the variable name from ENABLED to VISIBLE here (and at the call site).
Is there a way we can emulate and test the failing condition? E.g. some environment variable or launch technique where it will think it's in Hub enough to show these?
There was a problem hiding this comment.
Updated in the latest commit.
As for your question, I am not sure if there is any way to do that short of installing and launching JupyterHub itself. I can test it against my own environment, but if your aim was to have an automated test in this repo's CI that wouldn't really solve it.
There was a problem hiding this comment.
installing and launching JupyterHub itself.
I'll hoist to a separate issue: i feel like there must be a way to set up some dummy config values or environment variables to make it do the thing.
Signed-off-by: Luca Giorgi <[email protected]>
|
Thanks! |
Signed-off-by: Luca Giorgi [email protected]