Documentation updates and changes #264
Conversation
Escaped double baskslash within keyword documentation. Apparently RF escapes characters so when it sees the double backslash is interprets this as a single backslah when indeed it should be read as a double backslash. This fixes issues robotframework#200.
Added note to both 'Xpath Should Match X Times' and 'Get Matching Xpath Count' keywords stating that it is incorrect to add the 'xpath=' prefix to the locator as this is already assumed by the keyword. This fixes issue robotframework#228.
|
@emanlove, are these changes good to go? If you could rebase we can got ahead and get this PR closed. |
(Resolved) Conflicts: src/Selenium2Library/keywords/_element.py
|
Merged in recent changes with rtomac/master |
There was a problem hiding this comment.
I did have this conflict. Not sure which wording you prefer. My thoughts is that if it always has to be escaped there is not point in saying otherwise.
There was a problem hiding this comment.
I have just touched that Press Key documentation and code (it was missing
from an old PR).
With the new Press KeyS keyword we can use named keys instead of escaped
key codes.
On Tue, May 19, 2015 at 2:09 PM, Ed Manlove [email protected]
wrote:
In src/Selenium2Library/keywords/_element.py
#264 (comment)
:@@ -480,7 +480,7 @@ def press_key(self, locator, key):
"""Simulates user pressing key on element identified bylocator.`key` is either a single character, or a numerical ASCII code of the key
lead by '\'. In test data, '\' must be escaped, so use '\\'.lead by '\\'.I did have this conflict. Not sure which wording you prefer. My thoughts
is that if it always has to be escaped there is not point in saying
otherwise.—
Reply to this email directly or view it on GitHub
https://github.com/rtomac/robotframework-selenium2library/pull/264/files#r30596483
.
There was a problem hiding this comment.
I'm fine with how you have it.
|
You can merge this whenever you're ready, it looks good to me. |
|
@zephraph If you don't mind I'll let you or someone else merge the pull request. As habit i try not to ever merge my own pull requests (that is when I am on a project with others ;). Just a good habit I like to keep... |
Documentation updates and changes
3 participants
Contains the following changes