Skip to content

Fix DefaultNotificationBody defaultProps #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CocoJr wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix DefaultNotificationBody defaultProps #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d15b557
Fix DefaultNotificationBody defaultProps
May 7, 2019
0635e81
Fix package.json to create new NPM reusable package
May 7, 2019
a11e839
Render only if isOpen
May 7, 2019
9dd0f0b
Fix package.json
May 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,22 @@
{
"name": "react-native-in-app-notification",
"version": "3.0.0",
"description": "Customisable in-app notification component for React Native",
"name": "react-native-notification-in-app",
"version": "1.0.0",
"description": "Customisable in-app notification component for React Native - Fork of robcalcroft react-native-in-app-notification package.",
"main": "src/index.js",
"repository": "https://github.com/robcalcroft/react-native-in-app-notification.git",
"author": "Rob Calcroft <[email protected]>",
"repository": {
"type" : "git",
"url" : "https://github.com/CocoJr/react-native-in-app-notification"
},
"author": {
"name": "Thibault Colette",
"email": "[email protected]"
},
"contributors": [
{
"name": "Rob Calcroft",
"email": "[email protected]"
}
],
"license": "MIT",
"scripts": {
"lint": "eslint Notification.js DefaultNotificationBody.ios.js DefaultNotificationBody.android.js"
Expand Down
4 changes: 2 additions & 2 deletions src/DefaultNotificationBody/index.android.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,8 @@ DefaultNotificationBody.propTypes = {
};

DefaultNotificationBody.defaultProps = {
title: 'Notification',
message: 'This is a test notification',
title: null,
message: null,
vibrate: true,
isOpen: false,
iconApp: null,
Expand Down
4 changes: 2 additions & 2 deletions src/DefaultNotificationBody/index.ios.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,8 @@ DefaultNotificationBody.propTypes = {
};

DefaultNotificationBody.defaultProps = {
title: 'Notification',
message: 'This is a test notification',
title: null,
message: null,
vibrate: true,
isOpen: false,
iconApp: null,
Expand Down
2 changes: 1 addition & 1 deletion src/Notification.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ class Notification extends Component {

const height = baseHeight + this.heightOffset;

return (
return isOpen && (
<Animated.View
style={[
styles.notification,
Expand Down