This repository was archived by the owner on Jul 4, 2025. It is now read-only.
String tests #102
Merged
String tests #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Mmk @ashleygwilliams / @kadamwhite / @pete-the-pete – I tidied up this PR, and I'd love for y'all to review it if you had time. The last thing I want to do is squash the commits, but I figure I can do that right before merging. |
jamesplease
force-pushed
the
string-tests
branch
2 times, most recently
from
bc64f7b to
ccbf44c
Compare
|
The tests look OK, but it needs to be updated to account for #112: the strings module uses the old require declaration, rather than the |
|
this looks good to me @jmeas - if you squash i'll merge |
...I think I somehow managed to miss this comment altogether. I'll update thiz |
jamesplease
force-pushed
the
string-tests
branch
from
f0a5bd2 to
b250a2e
Compare
jamesplease
force-pushed
the
string-tests
branch
from
b250a2e to
e8e2c44
Compare
|
Updated @ashleygwilliams |
|
awesome @jmeas! merging |
|
🎀 |
|
Thanks, @ashleygwilliams! now I just need to get together some solutions :) |
kumarkalra
added a commit
to kumarkalra/js-assessment
that referenced
this pull request
Mar 14, 2016
add String tests Signed-off-by: Kumar Kalra <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pete-the-pete did some great work adding string tests over in #66. In this PR, I'm going to do some final tidying up of the PR, then squash it down for merge.