Skip to content

Conversation

@bmacer
Copy link
Contributor

@bmacer bmacer commented Dec 17, 2021

No description provided.

@bmacer
Copy link
Contributor Author

bmacer commented Dec 23, 2021

working at the current commit, i can cargo build --release and cargo test --all, but running cargo test -p pallet-rmrk-core i get:

error[E0277]: the trait bound `rmrk_traits::AccountIdOrCollectionNftTuple<AccountId>: Serialize` is not satisfied
    --> pallets/rmrk-core/src/types.rs:25:2
     |
25   |     /// The owner of the NFT, can be either an Account or a tuple (CollectionId, NftId)
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Serialize` is not implemented for `rmrk_traits::AccountIdOrCollectionNftTuple<AccountId>`

by my reading, it looks like the derive(Serialize, Deserialize) is in place as before. any ideas what might be causing this?

@bmacer
Copy link
Contributor Author

bmacer commented Dec 23, 2021

working at the current commit, i can cargo build --release and cargo test --all, but running cargo test -p pallet-rmrk-core i get:

error[E0277]: the trait bound `rmrk_traits::AccountIdOrCollectionNftTuple<AccountId>: Serialize` is not satisfied
    --> pallets/rmrk-core/src/types.rs:25:2
     |
25   |     /// The owner of the NFT, can be either an Account or a tuple (CollectionId, NftId)
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Serialize` is not implemented for `rmrk_traits::AccountIdOrCollectionNftTuple<AccountId>`

by my reading, it looks like the derive(Serialize, Deserialize) is in place as before. any ideas what might be causing this?

6335693 fixes this. had to remove a derive

@ilionic ilionic merged commit 1cca4ce into main Dec 28, 2021
@ilionic ilionic deleted the rework/rmrk-as-trait branch December 28, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants