Skip to content

Conversation

@ilionic
Copy link
Contributor

@ilionic ilionic commented Nov 6, 2022

Part of #241

  • Add mint_and_send_to_parent function which mints n items and sends to parent to create deep nested chain of nfts.
  • Benchmark burn_nft and reject_nft ( since it's using burn ) with n

@ilionic ilionic requested a review from Maar-io November 6, 2022 13:08
Copy link
Contributor

@Maar-io Maar-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since lookup_root_owner is recursive call and can be repeated n times, any function calling it should calculate weight according to this n.
Take a look for example at the set_priority()

@ilionic ilionic changed the title Benchmark deep nested calls Benchmark burn_nft call with deep nesting Nov 10, 2022
@ilionic ilionic marked this pull request as ready for review November 10, 2022 12:23
@ilionic ilionic merged commit a0c7373 into main Nov 22, 2022
@ilionic ilionic deleted the bechmark_nested_calls branch November 22, 2022 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants