Skip to content

make owner during minting optional #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ilionic merged 5 commits into from
Jun 10, 2022
Merged

make owner during minting optional #171

ilionic merged 5 commits into from
Jun 10, 2022

Conversation

@ilionic
Copy link
Contributor

@ilionic ilionic commented Jun 7, 2022 •
edited
Loading

Fixes #160

Haven't added explicit test, but it's implicit here:

rmrk-substrate/pallets/rmrk-core/src/tests.rs

Lines 54 to 57 in c3c969c

fn basic_mint() -> DispatchResult {
RMRKCore::mint_nft(
Origin::signed(ALICE),
None, // if not specified defaults to minter

@ilionic ilionic marked this pull request as ready for review June 7, 2022 22:53
@ilionic ilionic requested a review from bmacer June 7, 2022 22:53
@ilionic ilionic requested a review from HashWarlock June 8, 2022 09:36
bmacer
bmacer approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@bmacer bmacer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilionic ilionic merged commit 17b6c32 into main Jun 10, 2022
@ilionic ilionic deleted the mint-optional-owner branch June 10, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HashWarlock HashWarlock Awaiting requested review from HashWarlock

1 more reviewer

@bmacer bmacer bmacer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

In mint, owner should be optional

3 participants

@ilionic @bmacer