Support required arguments with default values [fixes #2356]

[modosc]

No description provided.

[modosc]

it looks like the failing specs are just order changes in the serialized hash:

-"{:required_with_default_arg=>1, :renamed=>\"x\"}"
+"{:renamed=>\"x\", :required_with_default_arg=>1}"

and they only happen on one version of ruby (although maybe they happen in others, given enough test runs). should i change those specs to deserialize so i can compare hash to hash or just not worry about it?

[rmosolgo]

Thanks for taking this on! Now that I see how this plays out in the tests, I think we'll benefit from this in GitHub too.

Regarding the failing test, I think it's because that run is with TESTING_INTERPRETER=1. With that env var, it uses the new interpreter runtime, which probably builds argument hashes in a different order.

I don't think the difference in behavior is significant. But to make the tests pass, how about ordering the keys in the hash before serializing it, for example:

sorted_keys = args.keys.sort 
sorted_args = {} 
sorted_keys.each  {|k| sorted_args[k] = args[k] }
sorted_args.inspect 

(Maybe there's a better way to sort the Hash -- but ya get the gist.)

What do you think of that?

[rmosolgo]

Ok, I think I finally get why this is good!

[modosc]

Regarding the failing test, I think it's because that run is with TESTING_INTERPRETER=1. With that env var, it uses the new interpreter runtime, which probably builds argument hashes in a different order.

ok, specs fixed and passing

[rmosolgo]

🤘

[modosc]

thanks @rmosolgo , any idea when 1.9.10 will land?