Skip to content

Conversation

HelloLudger
Copy link

Added HiddenWidget and hide HiddenFields by adding display: none to Wrapper within SchemaFields.js.

Sorry, no tests. Couldn't get the tests to run, in addition to my 0-knowledge of testing.

return (
<Wrapper
label={schema.title || name}
hidden={(uiSchema["ui:widget"] === "hidden" ? true : false)}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: uiSchema["ui:widget"] === "hidden" is good enough

@n1k0
Copy link
Collaborator

n1k0 commented Mar 4, 2016

We definitely want tests and documentation updated here. What prevents you running them? What error are you getting?

@HelloLudger
Copy link
Author

Maybe the problem is that I use Windows. I don't know. When I start npm test the error says that the command "NODEv_ENV" is not a viable command.

C:\Projekte\react-jsonschema-form>npm test

> [email protected] test C:\Projekte\react-jsonschema-form
> NODE_ENV=test mocha --compilers js:babel/register --recursive --require ./test/setup-jsdom.js $(find test -name '*_test.js')

Der Befehl "NODE_ENV" ist entweder falsch geschrieben oder
konnte nicht gefunden werden.
npm ERR! Test failed.  See above for more details.

@n1k0
Copy link
Collaborator

n1k0 commented Apr 3, 2016

Superseded by #111.

@n1k0 n1k0 closed this Apr 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants