Skip to content

Conversation

Algirdyz
Copy link
Contributor

@Algirdyz Algirdyz commented Jul 17, 2025

Reasons for making this change

Trying to finalize this PR: #4560

If this is related to existing tickets, include links to them as well. Use the syntax fixes #[issue number] (ex: fixes #123).

If your PR is non-trivial and you'd like to schedule a synchronous review, please add it to the weekly meeting agenda: https://docs.google.com/document/d/12PjTvv21k6LIky6bNQVnsplMLLnmEuypTLQF8a-8Wss/edit

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@Algirdyz Algirdyz marked this pull request as draft July 17, 2025 13:30
@Algirdyz Algirdyz changed the title Rjsf v6 Add Mantine theme Jul 17, 2025
@Algirdyz Algirdyz mentioned this pull request Jul 17, 2025
8 tasks
@heath-freenome
Copy link
Member

@Algirdyz Left you some feedback. Can you rebase and make sure that shadcn theme builds

@Algirdyz Algirdyz marked this pull request as ready for review July 18, 2025 10:02
@Algirdyz
Copy link
Contributor Author

Rebased, and updated based on review
Fixed shadcn build. Had to add "postcss-load-config": "^6.0.1" dependency. Not sure why main builds and this doesnt.

"access": "public"
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you restore the blank line at the end of the file?

Comment on lines 67 to 69
"@mantine/core": ">=7",
"@mantine/hooks": ">=7",
"@mantine/dates": ">=7"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are Mantine 7 and 8 totally compatible? Is Mantine 7 still supported? We want to reduce the frequency at which we have to publish breaking changes, so with that in mind, would it make sense to drop 7 and just support 8?

@heath-freenome
Copy link
Member

@Algirdyz it looks like you forgot to run npm run cs-format since there are lint errors in the build. Also, I would have expected the lint-staged code to have run the linters for you. What do you see when you run npm run prepare?

@Algirdyz
Copy link
Contributor Author

I am only getting this when I run npm run prepare

> prepare
> husky install

husky - install command is DEPRECATED

@Algirdyz
Copy link
Contributor Author

Mantine v8 was fully compatible in this case, just had to switch the version, no code changes required.

@Algirdyz
Copy link
Contributor Author

I can see that there is something wrong with the layoutgrid. I can't get the LayoutHeaderField to work properly.
Also what do you mean by screenshot? There already is a screenshot. Do you want me to replace that with the one of layoutgrid?

@Algirdyz
Copy link
Contributor Author

Ok fixed layoutgrid and added screenshots, is this what you wanted?

@zfarhad
Copy link
Contributor

zfarhad commented Jul 25, 2025

@heath-freenome Sorry for my late to response on #4560, I was unable to continue working on it due to my personal life commitments

@Algirdyz Thank you for continuing this work. If you need it, I am ready to contribute to complete it now.

@heath-freenome
Copy link
Member

Ok fixed layoutgrid and added screenshots, is this what you wanted?

@Algirdyz Sorry for the slow reply, busy work week. So I just wanted to see the layout grid screenshot attached as a comment to the PR rather than being code within the PR to make sure it looked right. Feel free to rebase and remove the screenshot from the actual codebase. I didn't mean to confuse you.

@Algirdyz
Copy link
Contributor Author

Ah I see, I just saw this screenshot in other themes so figured you wanted it there.

mantine-layoutgrid-screenshot

"jsdom": "^20.0.3",
"tailwindcss": "^3.0.0"
"tailwindcss": "^3.0.0",
"postcss-load-config": "^6.0.1"
Copy link
Contributor

@nickgros nickgros Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Why) is this needed for shadcn? Unexpected in this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, seems to no longer be needed. Previously it would give me error building shadcn saying this package was missing. Ayway, removed it.

@nickgros
Copy link
Contributor

nickgros commented Aug 6, 2025

@Algirdyz I think you just need to fix the new snapshot test and this is good to merge!

@heath-freenome
Copy link
Member

@Algirdyz I think you just need to fix the new snapshot test and this is good to merge!

Hopefully third time for getting this theme in is the charm. @Algirdyz I hope you have time to complete the work.

- Minor documentation cleanup
@heath-freenome heath-freenome merged commit 5060539 into rjsf-team:main Aug 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants