Chore: Update 3rd Party libraries to the latest #4583

heath-freenome · 2025-04-30T17:24:53Z

Reasons for making this change

Updated as many of the 3rd Party libraries as possible

Updated the root package.json to consolidate the dev dependencies from all of the sub-packages like:
- Typescript, rollup, jest, react, types and babel
- Also bumped all of the libraries that were out-of-date
Updated the individual package.json files to update libraries and to remove duplicated dev dependencies that are in the root package.json
Updated types in @rjsf/utils and @rjsf/core due to typescript and lodash type updates
Updated DemoFrame in playground to work with the latest version of react-frame-component
Updated all the snapshots for themes that needed them due to library updates
Updated docs libraries, including fixing up .md files that caused problems with the latest version of Docusaurus
Made @rjsf/utils isObject() a type guard

Checklist

I'm updating documentation
- I've checked the rendering of the Markdown text I've added
I'm adding or updating code
- I've added and/or updated tests. I've run npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update to update snapshots, if needed.
- I've updated docs if needed
- I've updated the changelog with a description of the PR
I'm adding a new feature
- I've updated the playground with an example use of the feature

packages/antd/package.json

nickgros · 2025-05-01T13:14:40Z

packages/playground/src/components/DemoFrame.tsx

@@ -74,7 +64,7 @@ export default function DemoFrame(props: DemoFrameProps) {
    );
    setContainer(instanceRef.current.contentDocument.body);
    setWindow(() => instanceRef.current.contentWindow);
-  }, []);
+  }, [instanceRef]);


I don't think this will do anything because the value of instanceRef will never change

technically the instanceRef.current can be changed during the mount/unmount... it is technically correct to have it there

But even when current changes, instanceRef will be the same object

True... And having it as a dependency doesn't hurt and is technically correct

nickgros · 2025-05-01T13:15:16Z

packages/playground/src/components/DemoFrame.tsx

-  const handleRef = useCallback(
-    (ref: any) => {
-      instanceRef.current = {
-        contentDocument: ref ? ref.node.contentDocument : null,
-        contentWindow: ref ? ref.node.contentWindow : null,
-      };
-    },
-    [instanceRef],
-  );


not needed anymore?

No, it the instanceRef is now directly set and does the same thing

nickgros · 2025-05-01T13:18:20Z

packages/utils/src/schema/getDefaultFormState.ts

        // Check if the parent schema has a const property defined AND we are supporting const as defaults, then we
        // should always return the computedDefault since it's coming from the const.
        const hasParentConst = isObject(parentConst) && (parentConst as JSONSchema7Object)[key] !== undefined;
        const hasConst =
-          ((isObject(propertySchema) && CONST_KEY in propertySchema) || hasParentConst) &&
+          ((typeof propertySchema === 'object' && CONST_KEY in propertySchema) || hasParentConst) &&


why was this changed?

type checking. Our isObject() function did not work as a type guard

Why not update isObject to be a typeguard? Think it would be as simple as

export default function isObject(thing: any): thing is object {

Hmm, let me try that

That works!

nickgros · 2025-05-01T13:23:05Z

packages/utils/src/types.ts

-    /** Allows RJSF to override the default field implementation by specifying either the name of a field that is used
-     * to look up an implementation from the `fields` list or an actual one-off `Field` component implementation itself
-     */
-    'ui:field'?: Field<T, S, F> | string;


Got it, MakeUIType will handle this with field defined in UIOptionsBaseType

nickgros · 2025-05-01T13:26:12Z

packages/antd/package.json

@@ -76,38 +76,17 @@
    "rc-picker": "2.7.6"
  },
  "devDependencies": {
-    "@ant-design/icons": "^5.6.1",
-    "@babel/cli": "^7.23.9",


fyi, if we switch to pnpm then we may still need to explicitly list the dependencies we are using in each package

Let's wait until we do that then. I wanted to reduce the size of our package files right now

nickgros

had some questions, not blocking approval

Updated as many of the 3rd Party libraries as possible - Updated the root `package.json` to consolidate the dev dependencies from all of the sub-packages like: - Typescript, rollup, jest, react, types and babel - Also bumped all of the libraries that were out-of-date - Updated the individual `package.json` files to update libraries and to remove duplicated dev dependencies that are in the root `package.json` - Updated types in `@rjsf/utils` and `@rjsf/core` due to typescript and lodash type updates - Updated `DemoFrame` in `playground` to work with the latest version of `react-frame-component` - Updated all the snapshots for themes that needed them due to library updates

… problems with the latest version of Docusaurus

…ltFormState.ts` changes

heath-freenome requested review from epicfaace and nickgros April 30, 2025 17:24

heath-freenome mentioned this pull request Apr 30, 2025

Added support for patternProperties #4582

Merged

heath-freenome force-pushed the Update-3rd-party-libs branch from 5fc91c8 to dfda08e Compare April 30, 2025 21:52

nickgros reviewed May 1, 2025

View reviewed changes

packages/antd/package.json Outdated Show resolved Hide resolved

nickgros reviewed May 1, 2025

View reviewed changes

nickgros approved these changes May 1, 2025

View reviewed changes

heath-freenome added 6 commits May 1, 2025 10:19

- Updated docs libraries, including fixing up .md files that caused…

9286f2d

… problems with the latest version of Docusaurus

- Fixed husky deprecation warning

1f1f789

- Responded to reviewer feedback

7110a61

- Made @rjsf/utils isObject() a type guard and reverted `getDefau…

9a722e2

…ltFormState.ts` changes

- Fixed additional typing issues from the patternProperties rebase

1923b75

heath-freenome force-pushed the Update-3rd-party-libs branch from 136b121 to 1923b75 Compare May 1, 2025 18:07

heath-freenome merged commit 1ecd15b into rjsf-v6 May 1, 2025
4 checks passed

heath-freenome deleted the Update-3rd-party-libs branch May 1, 2025 18:39

Chore: Update 3rd Party libraries to the latest #4583

Chore: Update 3rd Party libraries to the latest #4583

Uh oh!

Conversation

heath-freenome commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reasons for making this change

Checklist

Uh oh!

Uh oh!

nickgros May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nickgros left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

heath-freenome commented Apr 30, 2025 •

edited

Loading

nickgros May 1, 2025 •

edited

Loading