This repository was archived by the owner on Sep 17, 2024. It is now read-only.
chore!: rename scripts get -> fetch #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @NathanFlurry and the rest of your teammates on |
NathanFlurry
force-pushed
the
06-20-chore_rename_scripts_get_-_fetch
branch
from
c5cc9b1 to
85fe39f
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Renamed script functions and files for consistency (e.g.,
gettofetch,createUsertocreate) - Updated
authenticateUsertoauthenticateTokenacross multiple modules - Added optional
fetchUserparameter inauthenticate_token.ts - Ensured consistency in test files by updating function names
- No functional changes, only renaming for clarity and maintainability
26 file(s) reviewed, 1 comment(s)
Comment on lines
+28
to
+31
| if (req.fetchUser) { | ||
| user = await ctx.db.user.findFirstOrThrow({ | ||
| where: { id: userId }, | ||
| }); |
There was a problem hiding this comment.
Consider handling potential errors when fetching user details, such as user not found.
NathanFlurry
force-pushed
the
06-20-chore_rename_scripts_get_-_fetch
branch
from
85fe39f to
d02bea8
Compare
MasterPtato
approved these changes
Jun 22, 2024
This was referenced Jun 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(users): optionally return
userinauthenticate_token