Don't convert errors to strings before logging #1051
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently by calling
.Error()on job worker errors before logging them, data is being thrown away that cannot be used by slog handlers.I use a structured error library where errors can contain metadata like status codes or user IDs. In my slog handler I can extract these values and e.g. send this on to an error tracking service
But, this metadata isn't present in the basic
.Error()output and so it's being thrown away by this line which converts the error to a string.Instead I think you can use the
slog.Anyattribute type instead, by default this will have the same behaviour as the current code (printing out the error text), but allows custom slog handlers to extract the original error type