feat(iceberg): introduce remove snapshot action (#21) #77
+857
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Li0k
force-pushed
the
li0k/pick_82725fd1_to_dev_0808
branch
2 times, most recently
from
db988d4 to
a063986
Compare
chenzl25
reviewed
Sep 25, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the remove snapshot action feature to the Iceberg library, enabling snapshot expiration and cleanup operations. The implementation adds functionality to expire snapshots based on age, retention count, and specific snapshot IDs.
- Adds
RemoveSnapshotActiontransaction action with configurable expiration policies - Implements snapshot retention logic based on branch references and age thresholds
- Provides integration tests for the new snapshot expiration functionality
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
crates/iceberg/src/transaction/remove_snapshots.rs |
Core implementation of the remove snapshots action with retention logic |
crates/iceberg/src/transaction/mod.rs |
Exposes the new action through the transaction API |
crates/iceberg/src/spec/table_metadata.rs |
Adds constants for snapshot expiration configuration |
crates/iceberg/src/spec/snapshot.rs |
Adds ancestor iteration utilities for snapshot traversal |
crates/integration_tests/tests/shared_tests/remove_snapshots_test.rs |
Integration test for the new functionality |
crates/integration_tests/tests/shared_tests/mod.rs |
Registers the new test module |
crates/integration_tests/Cargo.toml |
Adds chrono dependency for timestamp handling |
crates/integration_tests/tests/shared_tests/append_data_file_test.rs |
Fixes data file writer reuse issue |
crates/iceberg/testdata/table_metadata/TableMetadataV2ValidMultiSnapshot.json |
Test data with multiple snapshots |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
* feat(iceberg): basic remove snapshot * feat(iceberg): introduce new properties for remove snapshots * feat(iceberg): support remove schemas * refactor(iceberg): refactor file org * address comments * refactor(iceberg): refactor and ut * fix(iceberg): fix integration-test typo fix: fix ut fix: fix test address comments address comments
Li0k
force-pushed
the
li0k/pick_82725fd1_to_dev_0808
branch
from
16d4e35 to
3ce36e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pick feat(iceberg): introduce remove snapshot action (#21)