fixup! feat: support incremental scan between 2 snapshots (#13) #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: refactor incremental scan
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the incremental scan implementation to share more common code with the full table scan, addressing concurrency issues and removing legacy paths.
- Added an early error for delete file processing when using incremental scan
- Replaced the custom incremental scan branch with a unified manifest file context builder
- Introduced a filter function for manifest entries in the scan processing logic
Comments suppressed due to low confidence (1)
crates/iceberg/src/scan.rs:246
- Consider enhancing the error message to include guidance on how to resolve the issue (e.g., instructions to disable delete_file_processing_enabled for incremental scans) to aid future debugging.
if self.delete_file_processing_enabled {
xxchan
merged commit d0fd9be
into
risingwavelabs:dev_rebase_main_20250307
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: refactor incremental scan
As pointed out at https://github.com/risingwavelabs/iceberg-rust/pull/13/files#r2004760818, the rushed original version is problematic. It didn't handle concurrency well.
So in this PR I refactored the implementation to share code path with normal full table scan as much as possible.