Skip to content

Conversation

klingaard
Copy link
Collaborator

Moved to almost the tip of Mavis. The head of Mavis requires c++23 features (@bdutro) which we might not be ready for yet.

Started to deprecate the use of nlohmann::json and moved to Boost::json. Can't remove it completely as FSL still uses it and we're pointing to a mirror (for now). Put that header in deprecated directory for now.

Also cleaned up some header file allocations to improve compile time.

@klingaard klingaard self-assigned this Oct 17, 2025
@bdutro
Copy link
Contributor

bdutro commented Oct 17, 2025

Mavis should compile cleanly with C++20 unless you're using a Clang version older than 16 (this branch has a preliminary fix for that: https://github.com/sparcians/mavis/tree/dev/bdutro/clang-15-std-views-fix).

@bdutro
Copy link
Contributor

bdutro commented Oct 17, 2025

I think you need to bump the minimum Boost version to 1.78.

@klingaard
Copy link
Collaborator Author

@bdutro I moved mavis to the latest for Olympia on my local box and get this compile issue with gcc v13.

/home/knutel/play/riscv-perf-model/mavis/mavis/ExtensionManager.hpp: In member function 'auto mavis::extension_manager::ExtensionMap::getFilteredView_(bool) const':
/home/knutel/play/riscv-perf-model/mavis/mavis/ExtensionManager.hpp:543:25: error: 'std::views' has not been declared
  543 |             return std::views::filter(enabled_extensions_, [include_meta](const auto & ext_pair)

@bdutro
Copy link
Contributor

bdutro commented Oct 20, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants