Skip to content

Rezazadeh93 update wallet endpoints #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rezazadeh93 merged 7 commits into from
Apr 15, 2022
Merged

Rezazadeh93 update wallet endpoints #2

rezazadeh93 merged 7 commits into from
Apr 15, 2022

Conversation

@ravesteijnd
Copy link

@ravesteijnd ravesteijnd commented Apr 15, 2022

  • Add missing withdrawOrderId
  • Use non-primitive types for non-mandatory fields to allow default null instead of 0.
  • Change parameter names to match naming used in Binance api doc
  • Add javadoc (copied from Binance api doc)

@ravesteijnd ravesteijnd mentioned this pull request Apr 15, 2022
Open
@rezazadeh93 rezazadeh93 merged commit 7ccae65 into rezazadeh93:update-wallet-endpoints Apr 15, 2022
@rezazadeh93
Copy link
Owner

rezazadeh93 commented Apr 15, 2022

great work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ravesteijnd @rezazadeh93