Skip to content

Conversation

@dmartingarcia
Copy link
Contributor

@dmartingarcia dmartingarcia commented Jun 15, 2022

Ticket 🎫

🔗 Jira ticket

Context 📓

Testing 🧪

Client applications PR's 📎

Will be deployed in the following PR: #8

Best Practices

In order to achieve a consensus on PRs and improve our workflow, the team has decided to agree on best practices Check them out!

Here is a list of them:

  • Keep the PR as small as possible, dividing it into different PRs if possible
  • Commits are descriptive and show information on the ticket journey
  • Explain reasons behind changes that might not be obvious or seem complex

@dmartingarcia dmartingarcia force-pushed the RETURN-11614-add-ci-builds branch from 031fd81 to e652a9a Compare June 17, 2022 10:19
@dmartingarcia dmartingarcia marked this pull request as ready for review June 17, 2022 11:54
@dmartingarcia dmartingarcia merged commit db0599d into master Jun 20, 2022
Comment on lines +46 to +48
- label: ":brakeman: Brakeman"
artifact_path: artifacts/brakeman.tabs
type: oneline
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have brakeman configured in this repo!

@dmartingarcia dmartingarcia deleted the RETURN-11614-add-ci-builds branch June 21, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants