-
Notifications
You must be signed in to change notification settings - Fork 14
Add lambda runtime support #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
slinkydeveloper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few things come in my mind when reading it:
- https://docs.aws.amazon.com/lambda/latest/dg/rust-http-events.html -> this gateway proxy event seems exactly the event we should be handling (first example paragraph)
- https://docs.aws.amazon.com/lambda/latest/dg/rust-logging.html#rust-logging-tracing -> Probably we need to double check this, maybe we need to add tracing instrument macro to the service thing
- You very much reimplemented the
impl Service<Request<Incoming>> for HyperEndpointhere in the lambda integration, i wonder if we could instead share some code just relying onhttpcrate types. Pretty sure most of the code is already there, just needs to be reorganized... - https://github.com/restatedev/sdk-rust/pull/70/files -> the endpoint api should not depend on the lambda thing imo. when you wrap
EndpointinLambdaEndpoint(and i think the user should do that explictly, same way they have to do that explicitly withHyperEndpoint) i guess you can force the discovery to be req/res... - we need to improve a bit more the documentation on
LambdaEndpointtype and describe how to deploy, link to the aws docs, etc. Plus probably we need an example template in theexamplesrepo. LambdaEndpointshould be re-exported in the prelude when the feature is enabled
|
Thanks @slinkydeveloper for your PR, I will try to answer here:
|
Perhaps a mention here: Line 31 in 24c829d
mhhh now that I look at this, i wonder if |
31b2ec0 to
c211b80
Compare
0cba357 to
7114c1d
Compare
5ebcb5b to
12637c0
Compare
Summary: This PR adds the support to run the user services on Amazon Lambda
Add lambda runtime support
Summary:
This PR adds the support to run the user services on Amazon Lambda