-
Notifications
You must be signed in to change notification settings - Fork 12
Add snapshot configuration links and examples to cluster pages #555
Conversation
6dcac1a to
03acdec
Compare
03acdec to
a382e2a
Compare
tillrohrmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating our documentation to instruct users to use snapshotting and how to set up minio @pcholakov. LGTM. +1 for merging :-)
|
|
||
| <Admonition type="caution"> | ||
| Snapshots are essential to support safe log trimming and also allow you to set partition replication to a subset of all cluster nodes, while still allowing for fast partition fail-over to to any live node. Snapshots are also necessary to add more nodes in the future. | ||
| </Admonition> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These change will probably conflict with #547
| If you plan to scale your cluster over time, we strongly recommend enabling snapshotting. | ||
| Without it, newly added nodes may not be fully utilized by the system. | ||
| See the [snapshotting documentation](/operate/data-backup#snapshotting) for more details. | ||
| See the [snapshotting documentation](/operate/snapshots) for more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here wrt to #547
| RESTATE_WORKER__SNAPSHOTS__DESTINATION: "s3://restate/snapshots" | ||
| RESTATE_WORKER__SNAPSHOTS__SNAPSHOT_INTERVAL_NUM_RECORDS: "1000" | ||
| RESTATE_WORKER__SNAPSHOTS__AWS_REGION: "local" | ||
| RESTATE_WORKER__SNAPSHOTS__AWS_ENDPOINT_URL: "http://minio:9000" | ||
| RESTATE_WORKER__SNAPSHOTS__AWS_ALLOW_HTTP: true | ||
| RESTATE_WORKER__SNAPSHOTS__AWS_ACCESS_KEY_ID: "minioadmin" | ||
| RESTATE_WORKER__SNAPSHOTS__AWS_SECRET_ACCESS_KEY: "minioadmin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that nothing changes here when merging restatedev/restate#2796, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, these all stay as-is -- #2796 is all about making the same functionality available under the RESTATE_METADATA_CLIENT__ prefix :-)
We want to steer users towards always using a snapshot repository. - expand Docker Compose example with Minio - update all cluster references to link to the snapshots page - add strong recommendation to always use snapshots for clusters
a4c3d57 to
7a6ac6f
Compare
|
Thanks for the review @tillrohrmann, I'll merge these now and help out with the conflicts under #547. |
We want to steer users towards always using a snapshot repository.