Skip to content
This repository was archived by the owner on Jun 15, 2023. It is now read-only.

Fix JSX v4 spec about configuration #719

Merged
merged 3 commits into from
Nov 6, 2022
Merged

Fix JSX v4 spec about configuration #719

merged 3 commits into from
Nov 6, 2022

Conversation

mununki
Copy link
Member

@mununki mununki commented Nov 6, 2022

This PR fixes the v3 compatible mode configuration example.

Co-authored-by: woonki <[email protected]>
@cristianoc
Copy link
Contributor

@mattdamon108
Other than the typo, how does it read -- is it clear enough?

@mununki
Copy link
Member Author

mununki commented Nov 6, 2022

@mattdamon108
Other than the typo, how does it read -- is it clear enough?

Yes! It looks clear now. Thanks!

@cristianoc cristianoc merged commit d56c139 into master Nov 6, 2022
@cristianoc
Copy link
Contributor

Need to move this to the compiler repo when the syntax repo changes are done.
I guess it does not matter having this on 10.1 and master is fine.

@mununki mununki deleted the fix-v3-conf branch November 6, 2022 23:38
cristianoc added a commit to rescript-lang/rescript that referenced this pull request Nov 7, 2022
Bring this last change after importing the syntax repo: rescript-lang/syntax#719
cristianoc added a commit to rescript-lang/rescript that referenced this pull request Nov 7, 2022
Bring this last change after importing the syntax repo: rescript-lang/syntax#719
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants