Skip to content
This repository was archived by the owner on Jun 15, 2023. It is now read-only.

Update parser + test runner to fail when in non-recover mode #146

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Update parser + test runner to fail when in non-recover mode #146

merged 1 commit into from
Sep 21, 2020

Conversation

@jchavarri
Copy link
Contributor

@jchavarri jchavarri commented Sep 20, 2020 •
edited
Loading

Extracted from #124.

  • Makes parser cli return exit code 1 if parsed result is invalid (except when -recover is passed)
  • Adapt runner to check status after calling rescript.exe, fail test if status > 0
  • Update test parsing/grammar/expressions/polyvariant.js that was failing to parse

@IwanKaramazow
Copy link
Contributor

IwanKaramazow commented Sep 21, 2020

@jchavarri perfect, nothing to add.

@IwanKaramazow IwanKaramazow merged commit ef260b2 into rescript-lang:master Sep 21, 2020
@jchavarri jchavarri deleted the fail-in-non-recover-mode branch September 21, 2020 20:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jchavarri @IwanKaramazow