Move is_local_dep to Dependency struct #7736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/win32-x64
commit: |
|
Agreed, |
|
Yes, I agree |
jfrolich
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm in a very confused state writing this, but this PR might hold an answer to rescript-lang/rewatch#124 (comment)
I could be wrong, but I don't think it makes sense to compile the
devDependenciesof your own non-local dependencies.In the sample of https://github.com/greenfinity/rescript-sample-v12, a local package has:
"bs-dependencies": ["rescript-nodejs"],.If I were to build that package with
--dev, I don't think we want to build anydevDependenciesofrescript-nodejs. Like, why would we? For all we know, the sources are missing as in thenode_modulesanyway.@jfrolich, @Bushuo, @cknitt any thoughts?