Skip to content

Remove dump command from rewatch cli #7710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2025
Merged

Remove dump command from rewatch cli #7710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f690a37
Remove dump command from rewatch cli
cknitt Jul 24, 2025
865d308
CHANGELOG
cknitt Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
#### :boom: Breaking Change

- `Result.getOrThrow` now throws a JS error instead of a `Not_found` ReScript exception. https://github.com/rescript-lang/rescript/pull/7630
- Remove `rescript dump` command. `bsc` can be used directly to dump the contents of a `.cmi` file instead if needed. https://github.com/rescript-lang/rescript/pull/7710

#### :rocket: New Feature

Expand Down
6 changes: 0 additions & 6 deletions rewatch/src/cli.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,12 +203,6 @@ pub enum Command {
#[arg(group = "format_input_mode", required_unless_present_any = ["format_input_mode"])]
files: Vec<String>,
},
/// Alias to `legacy dump`.
#[command(disable_help_flag = true)]
Dump {
#[arg(allow_hyphen_values = true, num_args = 0..)]
dump_args: Vec<OsString>,
},
/// This prints the compiler arguments. It expects the path to a rescript file (.res or .resi).
CompilerArgs {
/// Path to a rescript file (.res or .resi)
Expand Down
5 changes: 0 additions & 5 deletions rewatch/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,6 @@ fn main() -> Result<()> {
check,
files,
} => format::format(stdin, all, check, files),
cli::Command::Dump { mut dump_args } => {
dump_args.insert(0, "dump".into());
let code = build::pass_through_legacy(dump_args);
std::process::exit(code);
}
}
}

Expand Down