Skip to content

Add rust-version field to Rewatch's Cargo.toml #7701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2025
Merged

Add rust-version field to Rewatch's Cargo.toml #7701

merged 2 commits into from
Jul 23, 2025

Conversation

mediremi
Copy link
Contributor

We use Rust edition 2024, which means we require Rust v1.85+.

Attempting to compile Rewatch with an older version of Rust will now show the following error message:

$ make
./scripts/copyExes.js --ninja
cargo build --manifest-path rewatch/Cargo.toml --release
error: rustc 1.84.0 is not supported by the following packages:
  [email protected] requires rustc 1.85
  [email protected] requires rustc 1.85

make: *** [Makefile:19: rewatch] Error 101

@mediremi mediremi marked this pull request as ready for review July 23, 2025 09:51
tsnobip
tsnobip approved these changes Jul 23, 2025
View reviewed changes
Copy link
Member

@tsnobip tsnobip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mediremi!

@zth zth enabled auto-merge (squash) July 23, 2025 09:53
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 23, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7701

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7701

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7701

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7701

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7701

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7701

commit: 687710d

@zth zth merged commit cc27a5d into rescript-lang:master Jul 23, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsnobip tsnobip tsnobip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mediremi @tsnobip @zth