Skip to content

Remove pipe last (|>) syntax #7512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 24, 2025
Merged

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented May 23, 2025

In v11, |> was already removed by the formatter. Therefore we can fully remove that operator in v12.

Syntax tests were still containing a lot of |>. I just replaced all of those directly with ->, like in

      outputFile |> logFileAction(Identical)

->

      outputFile->logFileAction(Identical)

even though that's wouldn't actually compile because of the different parameter order.

@cknitt cknitt changed the title Remove pipe last Remove pipe last (|>) syntax May 23, 2025
@cknitt cknitt force-pushed the remove-pipe-last branch 3 times, most recently from 1082ba5 to 468ef68 Compare May 23, 2025 18:44
Copy link

pkg-pr-new bot commented May 23, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7512

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7512

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7512

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7512

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7512

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7512

commit: 97c2770

@cknitt cknitt force-pushed the remove-pipe-last branch from 468ef68 to b01921a Compare May 23, 2025 19:06
@cknitt cknitt force-pushed the remove-pipe-last branch from b01921a to 97c2770 Compare May 24, 2025 05:52
@cknitt cknitt requested review from zth and cristianoc May 24, 2025 06:05
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for it!

@cknitt cknitt merged commit 66723ba into rescript-lang:master May 24, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants