Fix missing checks for duplicate literals in variants with payloads. #7441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #7438 In variant definitions without payloads, an error is reported if two cases have the same literal `@as(literal)`. The check so far was missing for cases with payload, where the literal goes into the tag. However it's perfectly possible to use the same tag in a case without payload, and one with payloads, as the two representations don't overlap.
cristianoc
force-pushed
the
multiple_tags_variants
branch
from
8387450 to
c570d40
Compare
rescript
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/win32-x64
@rescript/darwin-arm64
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7438
In variant definitions without payloads, an error is reported if two cases have the same literal
@as(literal). The check so far was missing for cases with payload, where the literal goes into the tag. However it's perfectly possible to use the same tag in a case without payload, and one with payloads, as the two representations don't overlap.