Skip to content

add popover attributes #7317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 27, 2025
Merged

add popover attributes #7317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cf8e7cc
add popover attributes to jsxdom props
dkirchhof Feb 26, 2025
c944bc3
use popover type
dkirchhof Feb 26, 2025
cfc8935
add popoverTargetAction docs
dkirchhof Feb 26, 2025
cd165fd
add popover docs
dkirchhof Feb 26, 2025
40fa24e
Update test
nojaf Feb 27, 2025
9f3542e
Add changelog entry
nojaf Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@

# 12.0.0-alpha.10 (Unreleased)

#### :rocket: New Feature

- Add popover attributes to JsxDOM.domProps. https://github.com/rescript-lang/rescript/pull/7317

#### :house: Internal

- Clean up legacy tags handling. https://github.com/rescript-lang/rescript/pull/7309
Expand Down
11 changes: 11 additions & 0 deletions runtime/JsxDOM.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,14 @@

type style = JsxDOMStyle.t
type domRef
/**
[Read more on MDN](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/popover)
*/
type popover = | @as("auto") Auto | @as("manual") Manual | @as("hint") Hint
/**
[Read more on MDN](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#popovertargetaction)
*/
type popoverTargetAction = | @as("toggle") Toggle | @as("show") Show | @as("hide") Hide

/*
This list isn't exhaustive. We'll add more as we go.
Expand Down Expand Up @@ -146,6 +154,9 @@ type domProps = {
hidden?: bool,
id?: string,
lang?: string,
popover?: popover,
popoverTarget?: string,
popoverTargetAction?: popoverTargetAction,
role?: string /* ARIA role */,
style?: style,
spellCheck?: bool,
Expand Down
Loading