Skip to content

Conversation

cometkim
Copy link
Member

@cometkim cometkim commented Nov 8, 2024

@cometkim cometkim requested review from cknitt and cristianoc November 8, 2024 19:17
@cometkim cometkim mentioned this pull request Nov 9, 2024
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.
Just need to double-check possible conflicts of adding %.
E.g.3 % raw("0") parses as binary operator. It seems OK, but worth thinking about a little bit.

@cometkim
Copy link
Member Author

cometkim commented Nov 9, 2024

Looks great. Just need to double-check possible conflicts of adding %. E.g.3 % raw("0") parses as binary operator. It seems OK, but worth thinking about a little bit.

Yes, I noticed that %extension had a little ambiguity about space, but we're already enforcing % ext to be formatted to %ext.

@cometkim cometkim merged commit 971f935 into rescript-lang:master Nov 9, 2024
20 checks passed
@cometkim cometkim deleted the remainder branch November 9, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modulus Operator
2 participants