fix issue where record type spreads would not be picked up #6305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ord definition did not have a type spread at the very top
cristianoc
approved these changes
Jun 21, 2023
| lbls | ||
| |> List.exists (fun l -> | ||
| match l with | ||
| | {ld_name = {txt = "..."}} -> true |
There was a problem hiding this comment.
Does it make sense to have the treatment of spread somewhere (e.g. dedicated file)? E.g. no mention of "..." outside that file, or the has_spread functionality.
It might, or might not, be useful. What do you think?
There was a problem hiding this comment.
I think it might be useful, yeah. Might make sense to do it together with the next "feature" for type spreads, should we decide to do something like support type arguments.
|
Windows CI is red but everything else passes, so it doesn't seem to break because of these changes. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6293
The mechanism for processing record type spreads was only triggered if the record type definition had a spread at the top position. This ensures that type spreads will be processed regardless of if a type spread is at the top position.