Skip to content

Sync ninja: fix done not emitted with -w. #5544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 13, 2022
Merged

Sync ninja: fix done not emitted with -w. #5544

merged 5 commits into from
Jul 13, 2022

Conversation

cristianoc
Copy link
Collaborator

Fixes #5545

Commit: ed4d8abfb80826b73501f035ee01b1f2b15a9f53

@cristianoc
Copy link
Collaborator Author

Nope.

@cristianoc cristianoc closed this Jul 12, 2022
@cristianoc cristianoc deleted the sync-ninja branch July 12, 2022 15:55
@cristianoc cristianoc restored the sync-ninja branch July 13, 2022 03:04
@cristianoc cristianoc reopened this Jul 13, 2022
@cristianoc cristianoc merged commit 5a36541 into master Jul 13, 2022
@cristianoc cristianoc deleted the sync-ninja branch July 13, 2022 04:14
@cristianoc cristianoc mentioned this pull request Jul 13, 2022
6 tasks
mununki pushed a commit to mununki/rescript-compiler that referenced this pull request Jul 15, 2022
* Sync ninja: fix done not emitted with -w.

Fixes  https://github.com/rescript-lang/rescript-compiler/issues/5543

Commit: ed4d8abfb80826b73501f035ee01b1f2b15a9f53

* Executables from ninja CI

Ninja CI: https://github.com/rescript-lang/ninja/actions/runs/2660713164

* Sync ninja

commit 9e92c5fc853fe70c81f44fcbb093603c6d2a5098

* Synx ninja executables from CI.

CI: https://github.com/rescript-lang/ninja/actions/runs/2660898317

* Update Changes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler log unterminated on no-op build.
1 participant